improvements for Wifi shield #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to match actual API in the code
robertoostenveld
changed the title
|
Furthermore, testing the code with wifi+cyton I also made some small code changes. It now runs, but the time courses are not yet correct, i.e. all numbers are the same, and don't match the signals I can see with the same hardware in the OpenBCI GUI application. |
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=========================================
- Coverage 37.46% 37.3% -0.17%
=========================================
Files 9 9
Lines 1588 1595 +7
=========================================
Hits 595 595
- Misses 993 1000 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while reading through the code to find out how it deals with the (mostly undocumented) wifi shield, I have made some updated to the documentation.